Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 18, 2021

This PR is blocked by models/repository refactor because the test will load repository but repository model is not registered.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 18, 2021
@lunny lunny force-pushed the lunny/model_projectboard branch 3 times, most recently from 280968e to 3e5d2e6 Compare November 19, 2021 13:52
@lunny lunny added the pr/wip This PR is not ready for review label Nov 20, 2021
@lunny lunny force-pushed the lunny/model_projectboard branch from 3e5d2e6 to 892ada3 Compare November 24, 2021 04:54
@lunny lunny force-pushed the lunny/model_projectboard branch from 892ada3 to 15e64d7 Compare December 13, 2021 01:20
@lunny lunny removed the pr/wip This PR is not ready for review label Dec 13, 2021
@lafriks
Copy link
Member

lafriks commented Dec 13, 2021

unit tests are failing because of the changes

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2021
@lunny lunny force-pushed the lunny/model_projectboard branch from d7863f8 to 8c44762 Compare December 13, 2021 14:22
@lunny lunny mentioned this pull request Jan 25, 2022
@lunny lunny force-pushed the lunny/model_projectboard branch 3 times, most recently from 5ce705c to bf5dec2 Compare March 3, 2022 07:19
@lunny lunny added this to the 1.17.0 milestone Mar 3, 2022
@lunny lunny force-pushed the lunny/model_projectboard branch 2 times, most recently from 18fe3e1 to 8594d62 Compare March 23, 2022 07:40
@lunny lunny requested review from wxiaoguang and lafriks March 27, 2022 11:13
@lunny lunny force-pushed the lunny/model_projectboard branch from 8594d62 to c97d263 Compare March 29, 2022 07:01
@lunny lunny force-pushed the lunny/model_projectboard branch from 1cd4d43 to 460cb52 Compare March 29, 2022 11:40
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2022
@lunny lunny merged commit bd97736 into go-gitea:main Mar 29, 2022
@lunny lunny deleted the lunny/model_projectboard branch March 29, 2022 14:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2022
* giteaoffical/main: (31 commits)
  Add Package Registry (go-gitea#16510)
  Show messages for users if the ROOT_URL is wrong, show JavaScript errors (go-gitea#18971)
  [skip ci] Updated translations via Crowdin
  Make git.OpenRepository accept Context (go-gitea#19260)
  Use full output of git show-ref --tags to get tags for PushUpdateAddTag (go-gitea#19235)
  When conflicts have been previously detected ensure that they can be resolved (go-gitea#19247)
  More commit info from API (go-gitea#19252)
  Move some issue methods as functions (go-gitea#19255)
  Move project files into models/project sub package (go-gitea#17704)
  Granular webhook events in editHook (go-gitea#19251)
  Provide configuration to allow camo-media proxying (go-gitea#12802)
  Move init repository related functions to modules (go-gitea#19159)
  Move organization related structs into sub package (go-gitea#18518)
  Refactor repo clone button and repo clone links, fix JS error on empty repo page (go-gitea#19208)
  Show last cron messages on monitor page (go-gitea#19223)
  Allow API to create file on empty repo (go-gitea#19224)
  Use goproxy.io instead of goproxy.cn (go-gitea#19242)
  New cron task: delete old system notices (go-gitea#19219)
  Let web and API routes have different auth methods group (go-gitea#19168)
  Only send webhook events to active system webhooks and only deliver to active hooks (go-gitea#19234)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@wxiaoguang
Copy link
Contributor

  1. Do not rebase / force-push during refactoring
  2. Make all refactoring works complete as soon as possible (do not last longer than 1 week)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants