-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
In many cases user avatar link should be an absolute URL with http host #17420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5232a66 to
7d20c0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests pass
4bda920 to
45e0325
Compare
45e0325 to
d2fbf31
Compare
Codecov Report
@@ Coverage Diff @@
## main #17420 +/- ##
==========================================
+ Coverage 45.24% 45.40% +0.15%
==========================================
Files 789 791 +2
Lines 88441 88674 +233
==========================================
+ Hits 40017 40262 +245
+ Misses 41944 41900 -44
- Partials 6480 6512 +32
Continue to review full report at Codecov.
|
In many cases user avatar link should be an absolute URL with http host. eg: for API, for webhook.
The last PR (#17123) about user avatar refactoring make
AvatarLinkalways returns relative URL, it is incorrect.This PR makes
AvatarLinkreturn the absolute URL as before.