Skip to content

feat: upgrade drone docker image to support multi-stage build. #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2017
Merged

feat: upgrade drone docker image to support multi-stage build. #1732

merged 3 commits into from
Jul 11, 2017

Conversation

@appleboy
Copy link
Member

@appleboy appleboy commented May 16, 2017 •
edited
Loading

Since the PR drone-plugins/drone-docker#124 has been merged. We need to upgrade plugins/docker image before merge #1615

I don't have permission to update drone sig file.

cc @tboerger @lunny @sapk

@appleboy appleboy requested review from lunny and tboerger May 16, 2017 01:39
@appleboy appleboy added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 16, 2017
@appleboy appleboy requested a review from sapk May 16, 2017 01:41
@tboerger
Copy link
Member

tboerger commented May 16, 2017

AFAIK pull is not used for plugins.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2017
@appleboy
Copy link
Member Author

appleboy commented May 16, 2017 •
edited
Loading

@tboerger It is working on my drone server (0.6) with pull flag.

see http://drone.wu-boy.com/appleboy/gorush/46

@sapk
Copy link
Member

sapk commented May 24, 2017

@tboerger what do you suggest ? We could use tag (like image: plugins/docker:17.05) ?
I am not an expert in drone ^^ but I confirm that upgrating to 17.05 permit the usage of multi-stage Dockerfile.

So LGTM, except for the part of upgrating the image in drone that I don't handle.

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2017
@lunny lunny added this to the 1.3.0 milestone Jun 18, 2017
@sapk
Copy link
Member

sapk commented Jun 21, 2017 •
edited
Loading

This has worked for go-gitea/website#45 and go-gitea/docs#121. This will not have any effect on production (just force image update). Let's merge this ^^

@appleboy
Copy link
Member Author

appleboy commented Jun 21, 2017

@sapk Rebase the latest master branch. Waiting for drone build.

@appleboy appleboy modified the milestones: 1.2.0, 1.3.0 Jul 11, 2017
@lunny
Copy link
Member

lunny commented Jul 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 11, 2017
@appleboy appleboy merged commit da89afd into go-gitea:master Jul 11, 2017
@appleboy appleboy deleted the docker branch July 11, 2017 07:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny Awaiting requested review from lunny

@tboerger tboerger Awaiting requested review from tboerger

1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@appleboy @tboerger @sapk @lunny