Skip to content

Add option to copy line permalink #17145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 2, 2021
Merged

Add option to copy line permalink #17145

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df51d96
Add option to copy line permalink
qwerty287 Sep 24, 2021
8cd5d8c
Fix lint
qwerty287 Sep 24, 2021
58a6bc9
Apply review suggestions
qwerty287 Sep 25, 2021
27df643
Merge branch 'main' into line-permalink
qwerty287 Sep 25, 2021
1ed4f09
Update code and fix lint
qwerty287 Sep 25, 2021
a68ed7f
Merge branch 'main' into line-permalink
qwerty287 Sep 25, 2021
3adc23d
Use features/clipboard.js framework
qwerty287 Sep 27, 2021
2e43077
Merge branch 'line-permalink' of github.com:qwerty287/gitea into line…
qwerty287 Sep 27, 2021
555f884
Merge branch 'main' into line-permalink
qwerty287 Sep 27, 2021
2fcb31b
Merge branch 'main' into line-permalink
qwerty287 Oct 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,6 +969,7 @@ file_view_rendered = View Rendered
file_view_raw = View Raw
file_permalink = Permalink
file_too_large = The file is too large to be shown.
file_copy_permalink = Copy Permalink
video_not_supported_in_browser = Your browser does not support the HTML5 'video' tag.
audio_not_supported_in_browser = Your browser does not support the HTML5 'audio' tag.
stored_lfs = Stored with Git LFS
Expand Down
23 changes: 15 additions & 8 deletions templates/repo/view_file.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,20 @@
{{end}}
</tbody>
</table>
{{if $.Permission.CanRead $.UnitTypeIssues}}
<div class="code-line-menu ui fluid popup transition hidden">
<div class="ui column relaxed equal height">
<div class="column">
<div class="ui link list">
<a class="item ref-in-new-issue" href="{{.RepoLink}}/issues/new?body={{URLJoin AppUrl .RepoLink}}/src/commit/{{.CommitID}}/{{EscapePound .TreePath}}">{{.i18n.Tr "repo.issues.context.reference_issue"}}</a>
</div>
<div class="code-line-menu ui fluid popup transition hidden">
<div class="ui column relaxed equal height">
<div class="column">
{{if $.Permission.CanRead $.UnitTypeIssues}}
<div class="ui link list">
<a class="item ref-in-new-issue" href="{{.RepoLink}}/issues/new?body={{URLJoin AppUrl .RepoLink}}/src/commit/{{.CommitID}}/{{EscapePound .TreePath}}">{{.i18n.Tr "repo.issues.context.reference_issue"}}</a>
</div>
{{end}}
<div class="ui link list">
<a class="item copy-line-permalink" href="{{URLJoin AppUrl .RepoLink}}/src/commit/{{.CommitID}}/{{EscapePound .TreePath}}" onClick="return copy(this);">{{.i18n.Tr "repo.file_copy_permalink"}}</a>
</div>
</div>
{{end}}
</div>
</div>
{{end}}
{{end}}
</div>
Expand All @@ -137,4 +140,8 @@ function submitDeleteForm() {
$("#delete-file-form").submit()
}
}
function copy(link) {
navigator.clipboard.writeText(link.href);
return false;
}
</script>
20 changes: 18 additions & 2 deletions web_src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2927,8 +2927,9 @@ function selectRange($list, $select, $from) {

// add hashchange to permalink
const $issue = $('a.ref-in-new-issue');
const $copyPermalink = $('a.copy-line-permalink');

if ($issue.length === 0) {
if ($issue.length === 0 || $copyPermalink.length === 0) {
return;
}

Expand All @@ -2938,6 +2939,13 @@ function selectRange($list, $select, $from) {
} else {
$issue.attr('href', `${$issue.attr('href')}%23L${a}-L${b}`);
}

const matchedPermalink = $copyPermalink.attr('href').match(/#L\d+$|#L\d+-L\d+$/);
if (matchedPermalink) {
$copyPermalink.attr('href', $copyPermalink.attr('href').replace($copyPermalink.attr('href').substr(matchedPermalink.index), `#L${a}-L${b}`));
} else {
$copyPermalink.attr('href', `${$copyPermalink.attr('href')}#L${a}-L${b}`);
}
return;
}
}
Expand All @@ -2946,8 +2954,9 @@ function selectRange($list, $select, $from) {

// add hashchange to permalink
const $issue = $('a.ref-in-new-issue');
const $copyPermalink = $('a.copy-line-permalink');

if ($issue.length === 0) {
if ($issue.length === 0 || $copyPermalink.length === 0) {
return;
}

Expand All @@ -2957,6 +2966,13 @@ function selectRange($list, $select, $from) {
} else {
$issue.attr('href', `${$issue.attr('href')}%23${$select.attr('rel')}`);
}

const matchedPermalink = $copyPermalink.attr('href').match(/#L\d+$|#L\d+-L\d+$/);
if (matchedPermalink) {
$copyPermalink.attr('href', $copyPermalink.attr('href').replace($copyPermalink.attr('href').substr(matchedPermalink.index), `#${$select.attr('rel')}`));
} else {
$copyPermalink.attr('href', `${$copyPermalink.attr('href')}#${$select.attr('rel')}`);
}
}

$(() => {
Expand Down