- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 6.2k
 
Move db related basic functions to models/db #17075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c870928    to
    43f4e97      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
          Codecov Report
 @@            Coverage Diff             @@
##             main   #17075      +/-   ##
==========================================
+ Coverage   45.24%   45.25%   +0.01%     
==========================================
  Files         771      773       +2     
  Lines       86767    86828      +61     
==========================================
+ Hits        39255    39292      +37     
- Misses      41160    41181      +21     
- Partials     6352     6355       +3     
 Continue to review full report at Codecov. 
  | 
    
Since
modelsbecomes more and more big, splitting it becomes a task to refactor.This PR create a new subpackage
models/dband move common database functions to that package.The next PRs should create business logic related subpackages of
modelsand move related codes there. i.e. Moving allmodels/issue*.gotomodels/issues/.