Remove unused Fomantic sidebar module #16853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [Sidebar](https://fomantic-ui.com/modules/sidebar.html) module seems currently unused (at least I can't find any reference to it in templates or js), so remove it from the Fomantic build.
silverwind
added
topic/ui
6543
approved these changes
Aug 28, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Aug 29, 2021
GiteaBot
added
lgtm/done
|
🤖 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sidebar module seems currently unused (at least I can't find any reference to it in templates or js), so remove it from the Fomantic build, reducing frontend asset size by around 40kB before minification.
Also included are related changes which remove useless minified files output and mark those build files as being generated, so that they auto-collapse in diffs.