WIP: Set COMPATIBILITY_LEVEL in MSSQL testing #16628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR sets the COMPATIBILITY_LEVEL to 100 for the integrations tests on MSSQL. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
lafriks
approved these changes
Aug 5, 2021
GiteaBot
added
the
lgtm/need 1
|
I think this isn't doing what we intend as I far as I understand this should have failed the migration tests - either that or the migration in question isn't being tested here. In fact the current (at time of writing) failure of the #16627 implies that it definitely doesn't do what we hope it does. |
|
This isn't doing the right thing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the COMPATIBILITY_LEVEL to 100 for the integrations tests on MSSQL.
Signed-off-by: Andrew Thornton [email protected]