Skip to content

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Jul 19, 2021

Related to issue #16122, this patch is a continuation of #16139.

This patch allows users to use the delete button to delete a wiki page with a non-urlencoded file name.

@codecov-commenter
Copy link

Codecov Report

Merging #16482 (ed8586a) into main (0393a57) will increase coverage by 1.19%.
The diff coverage is 47.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16482      +/-   ##
==========================================
+ Coverage   44.24%   45.43%   +1.19%     
==========================================
  Files         695      718      +23     
  Lines       82341    84200    +1859     
==========================================
+ Hits        36429    38254    +1825     
+ Misses      40014    39793     -221     
- Partials     5898     6153     +255     
Impacted Files Coverage Δ
cmd/convert.go 0.00% <0.00%> (ø)
cmd/dump.go 0.91% <0.00%> (ø)
cmd/dump_repo.go 0.00% <0.00%> (ø)
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/migrate.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
cmd/restore_repo.go 0.00% <0.00%> (ø)
... and 317 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2256499...ed8586a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 19, 2021
@lunny lunny added this to the 1.16.0 milestone Jul 19, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 19, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 19, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 19, 2021
@6543 6543 merged commit e01b782 into go-gitea:main Jul 19, 2021
@6543
Copy link
Member

6543 commented Jul 19, 2021

@BLumia please send a backport :)

BLumia added a commit to BLumia/gitea that referenced this pull request Jul 19, 2021
* fix: support delete non-urlencoded wiki page

* fix: check error
@BLumia
Copy link
Member Author

BLumia commented Jul 19, 2021

@BLumia please send a backport :)

Done. see #16486 :)

@BLumia BLumia deleted the fix-wiki-delete branch July 19, 2021 16:21
@6543 6543 added the backport/done All backports for this PR have been created label Jul 19, 2021
6543 pushed a commit that referenced this pull request Jul 19, 2021
* fix: support delete non-urlencoded wiki page

* fix: check error
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* fix: support delete non-urlencoded wiki page

* fix: check error
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants