Skip to content

fix calculation for finalPage in repo-search component #16357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix calculation for finalPage in repo-search component #16357

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f03779f
fix calculation for finalPage in repo-search component
Jul 6, 2021
f3557d9
Merge branch 'main' into fix/too-many-pages-on-repo-paging-in-dashboard
6543 Jul 9, 2021
4e2fa90
Merge branch 'main' into fix/too-many-pages-on-repo-paging-in-dashboard
techknowlogick Jul 10, 2021
53e6f6a
Merge branch 'main' into fix/too-many-pages-on-repo-paging-in-dashboard
6543 Jul 10, 2021
98a8968
Merge branch 'main' into fix/too-many-pages-on-repo-paging-in-dashboard
6543 Jul 12, 2021
5bbf1db
Merge branch 'main' into fix/too-many-pages-on-repo-paging-in-dashboard
zeripath Jul 12, 2021
7400059
Merge branch 'main' into fix/too-many-pages-on-repo-paging-in-dashboard
6543 Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3389,7 +3389,7 @@ function initVueComponents() {
this.reposTotalCount = count;
}
Vue.set(this.counts, `${this.reposFilter}:${this.archivedFilter}:${this.privateFilter}`, count);
this.finalPage = Math.floor(count / this.searchLimit) + 1;
this.finalPage = Math.ceil(count / this.searchLimit);
this.updateHistory();
}
}).always(() => {
Expand Down