Second attempt at preventing zombies #16326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure that the pipes are closed in ssh.go * Ensure that a cancellable context is passed up in cmd/* http requests * Make cmd.fail return properly so defers are obeyed * Ensure that something is sent to stdout in case of blocks here Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
skip-changelog
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
a1012112796
reviewed
Jul 2, 2021
GiteaBot
added
the
lgtm/need 2
a1012112796
reviewed
Jul 2, 2021
a1012112796
reviewed
Jul 2, 2021
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #16326 +/- ##
==========================================
+ Coverage 44.24% 45.42% +1.18%
==========================================
Files 695 717 +22
Lines 82341 84162 +1821
==========================================
+ Hits 36429 38234 +1805
+ Misses 40014 39780 -234
- Partials 5898 6148 +250
Continue to review full report at Codecov.
|
|
Please can this get some reviews as it's holding up 1.15 now |
6543
reviewed
Jul 14, 2021
6543
approved these changes
Jul 14, 2021
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jul 14, 2021
GiteaBot
added
lgtm/done
|
🚀 |
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Second attempt at preventing zombies * Ensure that the pipes are closed in ssh.go * Ensure that a cancellable context is passed up in cmd/* http requests * Make cmd.fail return properly so defers are obeyed * Ensure that something is sent to stdout in case of blocks here Signed-off-by: Andrew Thornton <[email protected]> * placate lint Signed-off-by: Andrew Thornton <[email protected]> * placate lint 2 Signed-off-by: Andrew Thornton <[email protected]> * placate lint 3 Signed-off-by: Andrew Thornton <[email protected]> * fixup Signed-off-by: Andrew Thornton <[email protected]> * Apply suggestions from code review Co-authored-by: 6543 <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #16314
Signed-off-by: Andrew Thornton [email protected]