Enable race detection for unit tests #16239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enabling this just before a release seems like a good way to delay the release even further. |
GiteaBot
added
the
lgtm/need 2
|
I dont think the open pulls do have races in it and if so we should not merge them anyway! |
|
Yep, I agree with @zeripath . |
|
Race appears to break coverage results |
|
move for as long as it fails ... |
|
Maybe also enable race on integration will fix the coverage. |
|
the issue is you can not combine coverage files who have different test modiys (race & non race flag enabled) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #14723 got merged we should be able to enforce race detection for unit tests