Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Jun 9, 2021

created by grep 'git' go.mod | grep '\.com' | grep -v indirect | grep -v replace | cut -f 2 | cut -d ' ' -f 1 | while read line; do go get -u "$line"; make vendor; git add .; git commit -S -m "update $line"; done

@6543 6543 added this to the 1.15.0 milestone Jun 9, 2021
@zeripath
Copy link
Contributor

zeripath commented Jun 9, 2021

Looks like there is a change in one of the underlying packages meaning that the error code has changed:

469	        	            	-The email address is invalid.
388s
470	        	            	+Email address is not a valid email address.
388s

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 9, 2021
@6543
Copy link
Member Author

6543 commented Jun 9, 2021

1746186 caused it ...

@zeripath
Copy link
Contributor

zeripath commented Jun 9, 2021

I think you just have to skip that one - unless you can work out why that would happen.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2021
@techknowlogick
Copy link
Member

A note about bleve though: https://twitter.com/blevesearch/status/1401558497335156740 the 2.0.5 release is an emergency release due to a breaking upstream dependency of theirs that needed to be resolved.

@6543
Copy link
Member Author

6543 commented Jun 9, 2021

@techknowlogick yes noticed, we are affected by this too ...
... just because of vendoring, our CI did not break

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 10, 2021

I think you just have to skip that one - unless you can work out why that would happen.

Thats intended. In https://gitea.com/go-chi/binding/pulls/7 I fixed a bug in the form email validation which allowed a malformed address. Because of this there was a second check in Gitea needed:

gitea/models/user.go

Lines 876 to 878 in f088dc4

if err = ValidateEmail(u.Email); err != nil {
return err
}

This returns the error the test checks for. Now the form binding rejects the incorrect address which uses a different error message.

@6543
Copy link
Member Author

6543 commented Jun 10, 2021

@KN4CK3R will send a pull specific for that, this pull only bump dependencys

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2021
@6543 6543 merged commit 86e2789 into go-gitea:main Jun 10, 2021
@6543 6543 deleted the vendor_update branch June 10, 2021 14:44
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* update github.com/PuerkitoBio/goquery

* update github.com/alecthomas/chroma

* update github.com/blevesearch/bleve/v2

* update github.com/caddyserver/certmagic

* update github.com/go-enry/go-enry/v2

* update github.com/go-git/go-billy/v5

* update github.com/go-git/go-git/v5

* update github.com/go-redis/redis/v8

* update github.com/go-testfixtures/testfixtures/v3

* update github.com/jaytaylor/html2text

* update github.com/json-iterator/go

* update github.com/klauspost/compress

* update github.com/markbates/goth

* update github.com/mattn/go-isatty

* update github.com/mholt/archiver/v3

* update github.com/microcosm-cc/bluemonday

* update github.com/minio/minio-go/v7

* update github.com/prometheus/client_golang

* update github.com/unrolled/render

* update github.com/xanzy/go-gitlab

* update github.com/yuin/goldmark

* update github.com/yuin/goldmark-highlighting

Co-authored-by: techknowlogick <[email protected]>
@KN4CK3R KN4CK3R mentioned this pull request Oct 13, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants