Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 7, 2021

Fixes regression from #15219. Issue seen in title of https://try.gitea.io/silverwind/symlink-test/issues/6.

Frontend code that also outputs these images is not affected because StaticURLPrefix includes /assets there, while the same-named backend variable doesn't. We should later rename the frontend variable to clear up this potential confusion.

@silverwind silverwind added this to the 1.15.0 milestone May 7, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 7, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 7, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2021
@6543 6543 merged commit d4f28fd into go-gitea:main May 7, 2021
@silverwind silverwind deleted the emojiurl branch May 7, 2021 15:45
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants