Skip to content

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 25, 2021

Replaced repetitive code with the specific methods.

@KN4CK3R KN4CK3R added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15619 (9a8fe96) into master (3d5bb3e) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15619      +/-   ##
==========================================
+ Coverage   43.92%   43.93%   +0.01%     
==========================================
  Files         678      678              
  Lines       81741    81743       +2     
==========================================
+ Hits        35905    35915      +10     
+ Misses      39984    39977       -7     
+ Partials     5852     5851       -1     
Impacted Files Coverage Δ
routers/org/org.go 10.52% <0.00%> (ø)
routers/repo/issue_label.go 38.80% <0.00%> (ø)
routers/repo/setting.go 13.36% <0.00%> (ø)
modules/context/org.go 37.73% <50.00%> (ø)
routers/repo/pull.go 31.07% <50.00%> (ø)
routers/repo/repo.go 29.27% <50.00%> (ø)
models/user.go 53.15% <66.66%> (+0.08%) ⬆️
routers/repo/migrate.go 37.27% <100.00%> (ø)
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5bb3e...9a8fe96. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2021
@lunny
Copy link
Member

lunny commented Apr 26, 2021

I would like we use type Org = User and move all org related methods to the new struct`.

@techknowlogick techknowlogick added this to the 1.15.0 milestone Apr 26, 2021
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 26, 2021

I would like we use type Org = User and move all org related methods to the new struct`.

Do you have some methods in mind? After a short look I think only my new OrganizationLink is a match.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 26, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2021
@6543
Copy link
Member

6543 commented Apr 30, 2021

🚀

@6543 6543 merged commit c80d7f3 into go-gitea:master Apr 30, 2021
@KN4CK3R KN4CK3R deleted the refactor-unify-links branch May 7, 2021 06:30
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants