Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 22, 2021

followup of #15175

@6543 6543 added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15596 (3dd9d49) into master (834fc74) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15596      +/-   ##
==========================================
+ Coverage   43.81%   43.92%   +0.11%     
==========================================
  Files         678      678              
  Lines       81741    81741              
==========================================
+ Hits        35816    35907      +91     
+ Misses      40087    39979     -108     
- Partials     5838     5855      +17     
Impacted Files Coverage Δ
services/pull/pull.go 43.47% <0.00%> (+0.45%) ⬆️
routers/api/v1/repo/pull.go 28.74% <0.00%> (+0.59%) ⬆️
modules/notification/notification.go 87.60% <0.00%> (+2.47%) ⬆️
modules/notification/base/null.go 78.94% <0.00%> (+2.63%) ⬆️
modules/queue/manager.go 64.20% <0.00%> (+2.84%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/git/commit.go 56.47% <0.00%> (+4.31%) ⬆️
modules/notification/mail/mail.go 38.77% <0.00%> (+5.10%) ⬆️
modules/notification/ui/ui.go 64.10% <0.00%> (+5.12%) ⬆️
models/issue_comment.go 52.72% <0.00%> (+7.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834fc74...3dd9d49. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2021
@lunny
Copy link
Member

lunny commented Apr 23, 2021

It seems lint doesn't check tools folder.

@lunny lunny merged commit bee8ce3 into go-gitea:master Apr 23, 2021
@6543 6543 deleted the fix-go-fuzz branch April 23, 2021 15:15
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants