Skip to content

Use cat-file --batch in GetLanguageStats #14685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 17, 2021
Merged

Use cat-file --batch in GetLanguageStats #14685

merged 6 commits into from
Feb 17, 2021

Conversation

zeripath
Copy link
Contributor

This PR moves to using a single cat-file --batch in GetLanguageStats
significantly reducing the number of processes spawned during language stat
processing.

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Use cat-file --batch in GetLanguageStats
dc511f1 
This PR moves to using a single cat-file --batch in GetLanguageStats
significantly reducing the number of processes spawned during language stat
processing.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added performance/speed performance issues with slow downs performance/bigrepo Performance Issues affecting Big Repositories labels Feb 14, 2021
@zeripath zeripath added this to the 1.14.0 milestone Feb 14, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 14, 2021
@zeripath
Copy link
Contributor Author

I should add this needs #14682 to see its full effect. The Size() of the blobs is still being checked using the cat-file -s without #14682 so this only removes half of the excess calls.

@zeripath zeripath mentioned this pull request Feb 14, 2021
Merged
a1012112796
a1012112796 reviewed Feb 15, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 7ba1581 into go-gitea:master Feb 17, 2021
@zeripath zeripath deleted the cat-file-batch-repo-language-stats branch February 17, 2021 20:41
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@a1012112796 a1012112796 a1012112796 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/bigrepo Performance Issues affecting Big Repositories performance/speed performance issues with slow downs
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zeripath @techknowlogick @lunny @lafriks @a1012112796 @GiteaBot @6543