Skip to content

Fix GPG key deletion during account deletion (#14561) #14569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix GPG key deletion during account deletion (#14561) #14569

merged 1 commit into from
Feb 4, 2021

Conversation

anton-khimich
Copy link
Contributor

Backport of #14561.

Fix GPG key deletion during account deletion, backport of go-gitea#14561
925e6c0 


Per go-gitea#14531, deleting a user account will delete the user's GPG keys
from the `gpg_key` table but not from `gpg_key_import`, which causes
an error when creating an account with the same email and attempting
to re-add the same key. This commit deletes all entries from
`gpg_key_import` that match any GPG key IDs belonging to the user.
@6543 6543 changed the title Fix GPG key deletion during account deletion, backport of #14561 Fix GPG key deletion during account deletion (#14561) Feb 4, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 4, 2021
@6543 6543 added the type/bug label Feb 4, 2021
@6543 6543 added this to the 1.13.3 milestone Feb 4, 2021
richmahn
richmahn approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 4, 2021
@6543 6543 merged commit da7a525 into go-gitea:release/v1.13 Feb 4, 2021
@anton-khimich anton-khimich deleted the backport_14561_fix_gpg_key_deletion branch February 5, 2021 19:12
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+2 more reviewers

@zeripath zeripath zeripath approved these changes

@richmahn richmahn richmahn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.3
Development

Successfully merging this pull request may close these issues.
5 participants
@anton-khimich @zeripath @richmahn @6543 @GiteaBot