Fix bug about ListOptions and stars/watchers pagnation #14556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
6543
removed
the
skip-changelog
6543
approved these changes
Feb 4, 2021
GiteaBot
added
the
lgtm/need 1
|
ci fail is related ... |
6543
added
skip-changelog
zeripath
approved these changes
Feb 4, 2021
GiteaBot
added
lgtm/done
|
Please send backport. 🙂 |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 4, 2021
* Fix bug about ListOptions and stars/watchers pagnation * fix unit test Co-authored-by: 6543 <[email protected]>
|
Backport -> #14573 |
zeripath
pushed a commit
that referenced
this pull request
Feb 5, 2021
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Feb 9, 2021
* master: (22 commits) Add support for ref parameter to get raw file API (go-gitea#14602) Fixed irritating error message related to go version (go-gitea#14611) Use OldRef instead of CommitSHA for DeleteBranch comments (go-gitea#14604) Add information on how to build statically (go-gitea#14594) [skip ci] Updated translations via Crowdin Exclude the current dump file from the dump (go-gitea#14606) Remove spurious DataAsync Error logging (go-gitea#14599) [API] Add delete release by tag & fix unreleased inconsistency (go-gitea#14563) Fix rate limit bug when downloading assets on migrating from github (go-gitea#14564) [API] Add affected files of commits to commit struct (go-gitea#14579) [skip ci] Updated licenses and gitignores Fix locale init (go-gitea#14582) Add Content-Length header to HEAD requests (go-gitea#14542) Honor REGISTER_MANUAL_CONFIRM when doing openid registration (go-gitea#14548) Fix lfs file viewer (go-gitea#14568) Fix typo in generate-emoji.go (go-gitea#14570) Fix bug about ListOptions and stars/watchers pagnation (go-gitea#14556) Fix gpg key deletion (go-gitea#14561) [API] GetRelease by tag only return release (go-gitea#14397) Reduce data races (go-gitea#14549) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListOptionsis introduced by #9452. So there is maybe also some bugs on API pagination.For stars/watchers, the default pagesize should not be the same as ListOptions' default which will be
setting.API.DefaultPagingNum.And I also found that
forksalso needs pagination so I added aTODOcomment.Fix #14553