Skip to content

Set VERSION from git once, in a variable #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2017
Merged

Set VERSION from git once, in a variable #1447

merged 1 commit into from
Apr 6, 2017

Conversation

strk
Copy link
Member

@strk strk commented Apr 5, 2017

No description provided.

@lunny lunny added this to the 1.2.0 milestone Apr 5, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 5, 2017
@lunny
Copy link
Member

lunny commented Apr 5, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2017
@appleboy
Copy link
Member

appleboy commented Apr 6, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2017
@appleboy appleboy merged commit 410af69 into go-gitea:master Apr 6, 2017
@strk strk deleted the version branch April 10, 2017 19:46
bkcsoft added a commit that referenced this pull request Apr 28, 2017
@bkcsoft
Revert "Set VERSION from git once, in a variable (#1447)"
5e29152 
This reverts commit 410af69.
bkcsoft added a commit that referenced this pull request Apr 28, 2017
@bkcsoft
Revert "Set VERSION from git once, in a variable (#1447)"
cebe3a6 
This reverts commit 410af69.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@strk @lunny @appleboy @tboerger