Enable linting of JS inside templates and fix typo bug #13708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
silverwind
changed the title
techknowlogick
added
type/refactoring
Indentation-related rules are disabled because indent templates with tabs but our lint rules expect spaces. Also had to exclude a few files where using template variables in the JS is causing syntax errors for the JS parser. I don't think there's a way to solve this otherwise.
silverwind
force-pushed
the
htmljslint
branch
from
1096b8a to
af4a6cd
Compare
mrsdizzie
approved these changes
Nov 27, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Nov 27, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Nov 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables linting of inline scripts using eslint-plugin-html.
Had to exclude a few files where using template variables in the JS is causing syntax errors for the JS parser. I don't think there's a way to solve this otherwise.
Also contains a bugfix regarding a typo recently introduced, now caught by the linter.