Skip to content

Use CSS Vars for primary color #13361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2020
Merged

Use CSS Vars for primary color #13361

merged 3 commits into from
Oct 31, 2020

Conversation

silverwind
Copy link
Member

  • Create 15 color shades derived from primary color
  • Change blue-ish colors to use that primary color
  • Move styles for scrollbars, selection from arc-green to base
  • Remove obsolete arc-green styles that now use those variables

Screen Shot 2020-10-30 at 16 18 25

Screen Shot 2020-10-30 at 16 28 10

Screen Shot 2020-10-30 at 16 17 41

Screen Shot 2020-10-30 at 16 52 29

Screen Shot 2020-10-30 at 16 52 04

@silverwind
Use CSS Vars for primary color
85bcc90 
- Create 15 color shades derived from primary color
- Change blue-ish colors to use that primary color
- Move styles for scrollbars, selection from arc-green to base
- Remove obsolete arc-green styles that now use those variables
@zeripath
Copy link
Contributor

There are more than a few places in the templates where we use things like:

<span class="ui {{if not .Issue.NumComments}}gray{{else}}blue{{end}} small label">{{.Issue.NumComments}}</span>

I guess we should also migrate off calling these blue or gray and instead give them a semantic name too.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2020
@silverwind
Copy link
Member Author

silverwind commented Oct 30, 2020 •
edited
Loading

I guess we should also migrate off calling these blue or gray and instead give them a semantic name too.

Yeah, blue is currently mapped to the primary color for compatibilty but we should eventually change those cases to primary so blue will stay blue.

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Oct 30, 2020
@zeripath zeripath added this to the 1.14.0 milestone Oct 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 6c32367 into go-gitea:master Oct 31, 2020
@silverwind silverwind deleted the cssprimary branch October 31, 2020 08:11
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @zeripath @techknowlogick @GiteaBot