Skip to content

Conversation

@pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Mar 17, 2017

@strk This fixes the overlap you introduced in #618

@strk
Copy link
Member

strk commented Mar 18, 2017

is this change in staging for review?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2017
@strk
Copy link
Member

strk commented Mar 18, 2017

Trusted LGTM anyway

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2017
@lunny
Copy link
Member

lunny commented Mar 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2017
@lunny lunny merged commit b57b0c6 into go-gitea:master Mar 18, 2017
@strk
Copy link
Member

strk commented Mar 19, 2017

I still see an inconsistency in layout here: https://try.gitea.io/user/settings/openid

@strk
Copy link
Member

strk commented Mar 19, 2017

Version on try.gitea.io is 1.1.0+47-g1c3bd436 so it looks like it wasn't synced with latest merge from 21 hours ago ! @tboerger

@pgaskin pgaskin deleted the patch-7 branch May 24, 2017 01:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 23, 2025
This makes signed tags show a badge in the tag list similar to signed
commits in the commit list, and a more verbose block when viewing a
single tag. Works for both GPG and SSH signed tags.

Fixes go-gitea#1316.

Work sponsored by @glts.

Signed-off-by: Gergely Nagy <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants