Skip to content

Conversation

kolaente
Copy link
Member

This PR updates golangci-lint to the latest version 1.31.0.

The upgrade introduced a new check for which I've fixed or disabled most cases.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 11, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 11, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI ReplaceAll is golang version >1.12 - which is why it wasn't previously used.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 11, 2020
@zeripath zeripath added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug labels Oct 11, 2020
@zeripath zeripath added this to the 1.13.0 milestone Oct 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #13102 into master will increase coverage by 0.09%.
The diff coverage is 48.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13102      +/-   ##
==========================================
+ Coverage   42.41%   42.51%   +0.09%     
==========================================
  Files         673      673              
  Lines       74114    74113       -1     
==========================================
+ Hits        31436    31509      +73     
+ Misses      37581    37487      -94     
- Partials     5097     5117      +20     
Impacted Files Coverage Δ
models/migrations/migrations.go 2.46% <0.00%> (ø)
modules/repository/check.go 0.00% <0.00%> (ø)
modules/structs/hook.go 6.89% <0.00%> (ø)
modules/task/migrate.go 26.22% <0.00%> (+0.42%) ⬆️
modules/util/sanitize.go 37.50% <0.00%> (ø)
routers/install.go 0.00% <0.00%> (ø)
routers/repo/http.go 43.11% <0.00%> (ø)
routers/repo/view.go 38.11% <0.00%> (ø)
routers/utils/utils.go 72.00% <0.00%> (ø)
modules/webhook/slack.go 30.00% <50.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35f7e8...2be1025. Read the comment docs.

@6543
Copy link
Member

6543 commented Oct 11, 2020

🚀

@zeripath zeripath merged commit 6413312 into go-gitea:master Oct 11, 2020
@kolaente
Copy link
Member Author

FYI ReplaceAll is golang version >1.12 - which is why it wasn't previously used.

Ah makes sense, thanks for noting.

@kolaente kolaente deleted the update/golangci branch October 11, 2020 21:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants