Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 10, 2016

Since xorm have provide SQL and will deprecate Sql, so we can use SQL instead of Sql.

@lunny lunny added in progress type/enhancement An improvement of existing functionality labels Nov 10, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 10, 2016
@lunny lunny removed the in progress label Nov 10, 2016
@lunny
Copy link
Member Author

lunny commented Nov 10, 2016

It seems drone is not work.

@codecov-io
Copy link

codecov-io commented Nov 10, 2016

Current coverage is 3.14% (diff: 0.00%)

Merging #129 into master will not change coverage

@@            master      #129   diff @@
========================================
  Files           33        33          
  Lines         7823      7823          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7557      7557          
  Partials        20        20          

Powered by Codecov. Last update 145648a...7dcc3bc

@thibaultmeyer
Copy link
Contributor

LGTM

1 similar comment
@DblK
Copy link
Member

DblK commented Nov 10, 2016

LGTM

@DblK DblK added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 10, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 10, 2016

@lunny In my opinion we shouldn't use x.SQL unless absolutely necessary. If you're fixing all of them, why not change them to x.Select/x.Update etc?

@lunny
Copy link
Member Author

lunny commented Nov 10, 2016

SQL method allow you custom your SQL statement when ORM can not satisfy your requirements . Select and Update have beend used on other place.

@lunny lunny merged commit c6c840f into go-gitea:master Nov 10, 2016
@tboerger tboerger removed the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 12, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
@lunny lunny deleted the lunny/SQL_instead_Sql branch April 19, 2017 05:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants