Skip to content

Allow push to init a wiki repo #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2017
Merged

Allow push to init a wiki repo #1279

merged 2 commits into from
Mar 17, 2017

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 16, 2017

resolved #1278

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 16, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 16, 2017
appleboy
appleboy reviewed Mar 16, 2017
View reviewed changes
cmd/serv.go Outdated

if isWiki {
err = repo.InitWiki()
if err != nil {
Copy link
Member

@appleboy appleboy Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if err := repo.InitWiki(); err != nil {
....
}

more readable?

Copy link
Member

@bkcsoft bkcsoft Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a good idea to contain them (not that it matters here, but it's good practice)

Copy link
Member Author

@lunny lunny Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@bkcsoft
Copy link
Member

bkcsoft commented Mar 16, 2017

Other than that comment, LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 16, 2017
@strk
Copy link
Member

strk commented Mar 16, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2017
@lunny
Copy link
Member Author

lunny commented Mar 17, 2017

let L-G-T-M work

@lunny lunny merged commit ebbcf6f into go-gitea:master Mar 17, 2017
@lunny lunny deleted the lunny/fix_wiki_push_u branch March 17, 2017 04:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bkcsoft bkcsoft bkcsoft left review comments

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

Cannot push a wiki when there is not any wiki page.

5 participants

@lunny @bkcsoft @strk @appleboy @tboerger