Make copy/paste work for source code #12191

mrsdizzie · 2020-07-08T16:34:54Z

Fix regression casued by #12047 so copy/paste works properly in all browsers.

Also while looking at this I saw a small display issue for blame view. I think #12023 was merged into original PR through an update branch before #12047 was merged and made one of the css rules not apply anymore.

Also fix existing and unrelated bug where copy/paste from PR diff would select the + symbol from add comment features

Fix regression casued by go-gitea#12047 so copy/paste works properly in all browsers. Fixes go-gitea#12184 Also while looking at this I saw a small display issue for blame view. I think go-gitea#12023 was merged into original PR through an update branch before go-gitea#12047 was merged and made one of the css ruules not apply anymore.

silverwind · 2020-07-08T16:53:46Z

Looking pretty good now. One thing I've noticed it that copying two or more lines out of a diff appends a trailing newline in both Firefox and Chrome. It does not do that on the file view, and I think that newline should ideally not be copied.

mrsdizzie · 2020-07-08T16:54:38Z

@silverwind will take a look

mrsdizzie · 2020-07-08T17:05:23Z

Actually can't reproduce the diff issue -- can you link to an example to copy?

silverwind · 2020-07-08T17:15:06Z

Any diff like https://try.gitea.io/silverwind/updates/commit/7c5b7c608d95fa85644c05d9a33355511a3ae492

Select at least two lines, copy them and paste them into an editor and you'll notice the cursor being on the line after the two lines.

CirnoT · 2020-07-08T17:18:21Z

Can't reproduce on this PR @silverwind

@mrsdizzie Copying from PR diff view where you have [+] buttons for code comment still copies the '+' character from it on every line. This causes Firefox to place it in separate line while for Chromium it's placed on same line, before actual content.

Chromium:

## New features in version 2
+
+- 500+ new supported file types
+- Batch mode
+- Scan only mode to determine file types without extracting
+- Scan only mode to detect the type of any given file
+- Built-in updater
+- 100+ new supported file types

Firefox:

## New features in version 2
+

+
- 500+ new supported file types
+
- Batch mode
+
- Scan only mode to determine file types without extracting
+
- Scan only mode to detect the type of any given file
+
- Built-in updater
+
- 100+ new supported file types

Desired output:

## New features in version 2

- 500+ new supported file types
- Batch mode
- Scan only mode to determine file types without extracting
- Scan only mode to detect the type of any given file
- Built-in updater
- 100+ new supported file types

mrsdizzie · 2020-07-08T17:27:32Z

@CirnoT ah OK -- appears that it has always been like this for PR diff rather than a regression from recent changes. I'll try and fix it for this PR too since it should just be similar to regular diff

silverwind · 2020-07-08T17:30:37Z

Generally, adding user-select: none should make something like that [+] uncopyable.

…ot visually selected

mrsdizzie · 2020-07-08T17:59:15Z

@CirnoT should be fixed for PR diff -- seems ok in Firefox/Chrome from testing.

silverwind · 2020-07-08T19:07:28Z

Regarding the newline copying issue in diff, it seems to be because each line in the diff has a trailing newline which is not present on regular view lines. In regular file, there's no newline after the last chroma token (last <span>):

<code>  <span class="nt">"license"</span><span class="p">:</span> <span class="s2">"BSD-2-Clause"</span><span class="p">,</span></code>

but in diff view, there's a newline after it

<span class="mono wrap">  <span class="s2">"license"</span><span class="err">:</span> <span class="s2">"BSD-2-Clause"</span><span class="err">,</span>
</span>

Can we chop it off maybe?

mrsdizzie · 2020-07-08T19:45:50Z

@silverwind I pushed a change to fix that if you can test -- I see the new lines in the source but don't experience the copy/paste issue so can't verify that it would fix it.

CirnoT · 2020-07-08T19:52:17Z

@mrsdizzie It works fine now, thanks.

CirnoT · 2020-07-08T19:54:39Z

Actually the newest commit broke newlines again, they're no longer present on copy.

silverwind · 2020-07-08T19:55:32Z

Trailing newline is now fixed for me. @CirnoT which newlines exactly?

CirnoT · 2020-07-08T19:55:52Z

Between lines obviously

mrsdizzie · 2020-07-08T19:56:25Z

ah ok I see sheesh sorry, will fix next commit

silverwind · 2020-07-08T19:57:02Z

I mean diff or code view, or both? It does seem to work fine here in Firefox 79 and Chrome 83.

CirnoT · 2020-07-08T19:57:19Z

## New features in version 2
--
  |   |   |  
  |   |   | - 500+ new supported file types
  |   |   | - Batch mode
  |   |   | - Scan only mode to determine file types without extracting
  |   |   | - Scan only mode to detect the type of any given file
  |   |   | - Built-in updater
  |   |   | - 100+ new supported file types
  |   |   | - Audio and video extraction for multimedia files
  |   |   | - Cascading context menu
  |   |   | - Support for password list for common archives
  |   |   | - Improved optional status box with progress indicator
  |   |   | - Improved context menu integration and status box
  |   |   | - Better and faster file analysis
  |   |   | - Support for some extractors not shipping with UniExtract as plugins
  |   |   | - Silent mode, not showing any prompts
  |   |   | - Many interface improvements and redesigned dialogs
  |   |   | - Resource usage/speed improvements, lots of fixes
  |   |   | - Auto-using 64 bit versions of extractors if supported by OS
  |   |   | - Resource usage/speed improvements, lots of bug fixes

Is what I get when I copy this here on GH:

CirnoT · 2020-07-08T19:57:51Z

Copying it outside browser however produces this:

## New features in version 2
- 500+ new supported file types
- Batch mode
- Scan only mode to determine file types without extracting
- Scan only mode to detect the type of any given file
- Built-in updater
- 100+ new supported file types
- Audio and video extraction for multimedia files
- Cascading context menu
- Support for password list for common archives
- Improved optional status box with progress indicator
- Improved context menu integration and status box
- Better and faster file analysis
- Support for some extractors not shipping with UniExtract as plugins
- Silent mode, not showing any prompts
- Many interface improvements and redesigned dialogs
- Resource usage/speed improvements, lots of fixes
- Auto-using 64 bit versions of extractors if supported by OS
- Resource usage/speed improvements, lots of bug fixes

silverwind · 2020-07-08T19:58:49Z

I don't understand. Where do you paste to get these vertical lines?

CirnoT · 2020-07-08T19:59:09Z

Just here in GH textarea, I guess it adds it for some reason? Pasting it in raw <textarea> on simple HTML page results in

## New features in version 2
- 500+ new supported file types
- Batch mode
- Scan only mode to determine file types without extracting
- Scan only mode to detect the type of any given file
- Built-in updater
- 100+ new supported file types
- Audio and video extraction for multimedia files
- Cascading context menu
- Support for password list for common archives
- Improved optional status box with progress indicator
- Improved context menu integration and status box
- Better and faster file analysis
- Support for some extractors not shipping with UniExtract as plugins
- Silent mode, not showing any prompts
- Many interface improvements and redesigned dialogs
- Resource usage/speed improvements, lots of fixes
- Auto-using 64 bit versions of extractors if supported by OS
- Resource usage/speed improvements, lots of bug fixes

Note the missing empty newline

silverwind · 2020-07-08T20:00:55Z

Indeed, I see very strange paste results when copy/pasting inside Firefox but it does work normally when I paste into an external editor, wtf.

CirnoT · 2020-07-08T20:01:26Z

What OS if I can ask @silverwind. Neither me nor @mrsdizzie can't reproduce your original report about stray newline at the end?

silverwind · 2020-07-08T20:02:22Z

Final newline issue was both in Windows and macOS, Firefox and Chrome. Thought in Chrome, not always.

CirnoT · 2020-07-08T20:02:22Z

Must be some GH feature; try it on any other site that has simple unmodified <textarea> element.

CirnoT · 2020-07-08T20:02:44Z

Windows here, could not reproduce on Chrome and Firefox alike.

CirnoT · 2020-07-08T20:04:49Z

I can reproduce it If i try, by which I mean specifically try to move cursor so that it catches empty element on next line by ending drag selection on line below. I wouldn't consider that a bug however?

silverwind · 2020-07-08T20:08:13Z

Yeah apparantly GH textarea does magic to break pasted text, nice. Try pasting into a pristine textarea like https://jsfiddle.net/silverwind/znpcLo4w/.

Not sure what else to tell you, I start selection on bottom right of the line, move cursor to top left, hit copy and then paste.

Current version is LGTM.

CirnoT · 2020-07-08T20:09:51Z

No, the current version does not preserve empty newlines on diff view

mrsdizzie · 2020-07-08T20:09:58Z

@CirnoT I believe that last push should fix copying newline in diff again

silverwind · 2020-07-08T20:10:31Z

Ah right, I can see the empty newline issue too. Testing latest fix.

silverwind · 2020-07-08T20:12:16Z

Confirming everything working now for me.

CirnoT · 2020-07-08T20:12:40Z

Works fine now here too

zeripath · 2020-07-08T21:02:22Z

Make lg-tm work

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2020

use pseudo-element to prevent copying of comment + symbol even when n…

55a71d7

…ot visually selected

lafriks added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 8, 2020

lafriks added this to the 1.13.0 milestone Jul 8, 2020

remove added newline here should not be necessary anymore

bd8d88a

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 8, 2020

make sure empty line is newline so there is something to select and copy

24fa667

CirnoT approved these changes Jul 8, 2020

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2020

silverwind approved these changes Jul 8, 2020

View reviewed changes

Merge branch 'master' into fix-12184

b5b5f00

zeripath merged commit a6168fa into go-gitea:master Jul 8, 2020

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Uh oh!

Make copy/paste work for source code #12191

Make copy/paste work for source code #12191

Uh oh!

Conversation

mrsdizzie commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

mrsdizzie commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

silverwind commented Jul 8, 2020

Uh oh!

CirnoT commented Jul 8, 2020

Uh oh!

zeripath commented Jul 8, 2020

Uh oh!

mrsdizzie commented Jul 8, 2020 •

edited

Loading

CirnoT commented Jul 8, 2020 •

edited

Loading

silverwind commented Jul 8, 2020 •

edited

Loading

silverwind commented Jul 8, 2020 •

edited

Loading

CirnoT commented Jul 8, 2020 •

edited

Loading

CirnoT commented Jul 8, 2020 •

edited

Loading

silverwind commented Jul 8, 2020 •

edited

Loading