[Workaround] doctor xorm.Count nil on sqlite error #11741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
zeripath
approved these changes
Jun 8, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jun 9, 2020
GiteaBot
added
lgtm/done
lunny
reviewed
Jun 17, 2020
Member
lunny
left a comment
lunny
left a comment
There was a problem hiding this comment.
The bug resulted in all places which invoke DeleteOrphanedObjects.
| From("`"+subject+"`"). | ||
| Join("LEFT", "`"+refobject+"`", joinCond). | ||
| Where(builder.IsNull{"`" + refobject + "`.id"})). | ||
| Delete("`" + subject + "`") |
Member
There was a problem hiding this comment.
This is not supported by xorm. Delete needs an point but not a string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since I dont think xorm will be updated in v1.11 branch - fix it with an workaround
fix #11734