Fix verification of subkeys of default gpg key #11713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#10309 Signed-off-by: Andrew Thornton <[email protected]>
…hen-verifying-default-key
7 tasks
CirnoT
reviewed
May 31, 2020
GiteaBot
added
the
lgtm/need 2
zeripath
commented
Jun 1, 2020
…hen-verifying-default-key
Contributor
Author
|
I'm suspicious that this may actually fix #10591 too |
Member
|
@zeripath can you add a test for this case :) |
Signed-off-by: Andrew Thornton <[email protected]>
…at-we-provide-subkeys-when-verifying-default-key
…-default-key' of github.com:zeripath/gitea into fix-10309-ensure-that-we-provide-subkeys-when-verifying-default-key
6543
approved these changes
Jun 2, 2020
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jun 3, 2020
GiteaBot
added
lgtm/done
…hen-verifying-default-key
Member
|
ping LG-TM |
Member
|
@zeripath please send backport :) |
zeripath
deleted the
fix-10309-ensure-that-we-provide-subkeys-when-verifying-default-key
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 3, 2020
* Fix verification of subkeys of default gpg key Fix go-gitea#10309 Signed-off-by: Andrew Thornton <[email protected]> * Remove debug log * Update models/gpg_key.go * As per @6543 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
zeripath
added a commit
that referenced
this pull request
Jun 3, 2020
* Fix verification of subkeys of default gpg key Fix #10309 Signed-off-by: Andrew Thornton <[email protected]> * Remove debug log * Update models/gpg_key.go * As per @6543 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 15, 2020
Backport go-gitea#11713 * Fix verification of subkeys of default gpg key Fix go-gitea#10309 Signed-off-by: Andrew Thornton <[email protected]> * Remove debug log * Update models/gpg_key.go * As per @6543 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
techknowlogick
added a commit
that referenced
this pull request
Jun 15, 2020
Backport #11713 * Fix verification of subkeys of default gpg key Fix #10309 Signed-off-by: Andrew Thornton <[email protected]> * Remove debug log * Update models/gpg_key.go * As per @6543 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix verification of subkeys of default gpg key Fix go-gitea#10309 Signed-off-by: Andrew Thornton <[email protected]> * Remove debug log * Update models/gpg_key.go * As per @6543 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10309
Signed-off-by: Andrew Thornton [email protected]