Skip to content

Change language statistics to save size instead of percentage (#11681) #11690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2020
Merged

Change language statistics to save size instead of percentage (#11681) #11690

merged 2 commits into from
Jun 2, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 30, 2020 •
edited
Loading

Backport #11681 & #11692

@lafriks lafriks added the type/enhancement An improvement of existing functionality label May 30, 2020
@lafriks lafriks added this to the 1.12.0 milestone May 30, 2020
@lafriks lafriks added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label May 30, 2020
@lafriks
Copy link
Member Author

lafriks commented May 30, 2020

More fixes are coming

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2020
lunny
lunny reviewed May 30, 2020
View reviewed changes
@CirnoT
Copy link
Contributor

CirnoT commented Jun 1, 2020

Please integrate #11692

lafriks and others added 2 commits June 1, 2020 21:42
@lafriks @CirnoT
Change language statistics to save size instead of percentage (go-git…
0657bd3 
…ea#11681)

* Change language statistics to save size instead of percentage in database

Co-Authored-By: Cirno the Strongest <[email protected]>

* Do not exclude if only language

* Fix edge cases with special langauges

Co-authored-by: Cirno the Strongest <[email protected]>
@CirnoT @lafriks
Fix language stat calculation (go-gitea#11692)
855f730 
* Fix language stat calculation

* Group languages and ignore 0 size files

* remove unneeded code
@lafriks lafriks force-pushed the backport/fix/lagstat_storage branch from bbb01e0 to 855f730 Compare June 1, 2020 18:42
@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jun 1, 2020
@lafriks
Copy link
Member Author

lafriks commented Jun 1, 2020

@CirnoT done

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 1, 2020
@lafriks
Copy link
Member Author

lafriks commented Jun 2, 2020

Make lgtm work

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 2, 2020
@lafriks lafriks merged commit a34826b into go-gitea:release/v1.12 Jun 2, 2020
@lafriks lafriks deleted the backport/fix/lagstat_storage branch June 2, 2020 17:55
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@CirnoT CirnoT CirnoT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @CirnoT @lunny @techknowlogick @GiteaBot