Handle expected errors in AddGPGkey API #11644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
needed for #11641 |
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
May 27, 2020
GiteaBot
added
lgtm/need 1
Contributor
|
I don't think this is breaking. This might sound a bit harsh but we never said that 500 was a valid result - so although people might have been using it - it does not form an advertised API. TBH If they had been using the 500 they should have reported it as a bug. |
zeripath
changed the title
lafriks
approved these changes
May 28, 2020
GiteaBot
added
lgtm/done
Member
Author
|
ready to merge |
Member
|
@6543 please backport :) |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
May 28, 2020
* handle GPG Parse & Email Errors * correct TEST * update Swagger * more Docu
Member
Author
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
May 28, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* handle GPG Parse & Email Errors * correct TEST * update Swagger * more Docu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title