Skip to content

Fix footer padding for comment code reply form on issue event view #11469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2020
Merged

Fix footer padding for comment code reply form on issue event view #11469

merged 2 commits into from
May 18, 2020

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 17, 2020

Before:
firefox_2020-05-17_23-17-02

After:
firefox_2020-05-17_23-17-12

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2020
@6543
Copy link
Member

6543 commented May 17, 2020

🚀

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 18, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 18, 2020
@zeripath
Copy link
Contributor

Make lg-tm work

@zeripath zeripath merged commit e7e0097 into go-gitea:master May 18, 2020
@zeripath zeripath mentioned this pull request May 18, 2020
Merged
@CirnoT CirnoT deleted the issue_event-code-comment_footer branch May 18, 2020 06:24
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request May 18, 2020
@CirnoT @lafriks
Fix footer padding for comment code reply form on issue event view (g…
474a0b8 
…o-gitea#11469)
@lafriks lafriks added the backport/done All backports for this PR have been created label May 18, 2020
zeripath pushed a commit that referenced this pull request May 18, 2020
@lafriks @CirnoT
Fix comment box styling and cancelling (#11463) (#11464) (#11469) (#1…
6e75bc0 
…1467)

* Fix styling of resolved code comment box (#11463)

Co-authored-by: Lauris BH <[email protected]>

* Fix .comment-code-cloud not being removed when cancelling new code comment (#11464)

* Fix footer padding for comment code reply form on issue event view (#11469)

Co-authored-by: Cirno the Strongest <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Fix footer padding for comment code reply form on issue event view (g…
23b64ef 
…o-gitea#11469)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

7 participants

@CirnoT @6543 @zeripath @mrsdizzie @lafriks @GiteaBot @lunny