Skip to content

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 16, 2020

Fixes this:
chrome_2020-05-17_00-50-53

@CirnoT
Copy link
Contributor Author

CirnoT commented May 16, 2020

Do we even want to keep show lock icon on public repos belonging to private orgs? Seems wrong to me. Realistically the only ones that would see that list are org members.

Or maybe change the color of lock icon to black?

Of note is that actual icon on repo page is normal one, not lock.

#11445

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2020
@lunny
Copy link
Member

lunny commented May 17, 2020

We should use different icons for

  • private repositories -> lock icons
  • public repositories of individual or public orgnization -> public icons
  • public repositories of private orgnization -> limit icons

@CirnoT
Copy link
Contributor Author

CirnoT commented May 17, 2020

public repositories of individual or public orgnization -> public icons

Public repos have no icon on list at the moment, just like on GitHub

public repositories of private orgnization -> limit icons

Any idea what such icon would be?

@lunny
Copy link
Member

lunny commented May 17, 2020

No suitable icon on octicons

@CirnoT
Copy link
Contributor Author

CirnoT commented May 17, 2020

#11445

@CirnoT CirnoT closed this May 17, 2020
@CirnoT CirnoT deleted the repo_list-lock branch May 17, 2020 17:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants