Skip to content

Conversation

@avelino
Copy link

@avelino avelino commented Nov 8, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 8, 2016

Current coverage is 2.27% (diff: 100%)

Merging #113 into master will increase coverage by 0.02%

@@            master      #113   diff @@
========================================
  Files           32        32          
  Lines         7523      7523          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
+ Hits           169       171     +2   
+ Misses        7337      7336     -1   
+ Partials        17        16     -1   

Powered by Codecov. Last update 5667d4d...b4671c9

@strk
Copy link
Member

strk commented Nov 8, 2016

LGTM, although we didn't yet define a policy for updating those files...

@lunny
Copy link
Member

lunny commented Nov 8, 2016

If we accept #114, so we can merge this? Or we have to use a tanslation tool to do that?

@strk
Copy link
Member

strk commented Nov 8, 2016

#114 seems to be more than a policy, it's actually a proposal for a new development.
A policy could be something as simple as: "translation updates are accepted as pull-requests"

@lunny
Copy link
Member

lunny commented Nov 8, 2016

Yes. So let's LGTM first!

@lunny lunny merged commit e06e0f9 into go-gitea:master Nov 8, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 12, 2016
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 12, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
…gitea#113)

* Adds TogetherJS to editor

Adds Scrollbars and fixed height to editor

* Added some TogetherJS config

* Fixes per code review

* Generated index.css

* Moved editor css to the correct .less files

* Generated index.css
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
…o-gitea#113)

* GetCommit() returns a ErrNotExist if short commit ID does not exists

Currently, GetCommit() returns a generic error if a short commit ID
does not exists in a repository.

When a commit is not found by git-rev-parse, it returns an errors
which contains "fatal: ambiguous argument". GetCommit() now search if
the error contains this string, and, if it does, returns an
ErrNotExist.

The idea is to allow commits to be accessed from gitea with a short
commit ID.  Without this change, it would return a 500 Internal Server
Error when a short ID does not exists in the repository.

Signed-off-by: Alban Gruin <[email protected]>

* GetCommit(): change the comparison for short commit messages

`fatal: ambiguous argument` can be the beginning of two errors in
git. This changes the comparison to something less ambiguous.

Signed-off-by: Alban Gruin <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants