Skip to content

When migrating from Gitlab map Approvals to approving Reviews #11147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 20, 2020
Merged

When migrating from Gitlab map Approvals to approving Reviews #11147

merged 10 commits into from
Apr 20, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 19, 2020 •
edited
Loading

close #11137

@6543 6543 force-pushed the migrations-gitlab-add-reviews branch from 039cc35 to 3e16f78 Compare April 19, 2020 22:49
@codecov-io
Copy link

codecov-io commented Apr 19, 2020 •
edited
Loading

Codecov Report

Merging #11147 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11147      +/-   ##
==========================================
- Coverage   43.22%   43.22%   -0.01%     
==========================================
  Files         601      601              
  Lines       85544    85575      +31     
==========================================
+ Hits        36980    36991      +11     
- Misses      43999    44007       +8     
- Partials     4565     4577      +12
Impacted Files Coverage Δ
modules/migrations/base/pullrequest.go 0.00% <ø> (ø)
modules/migrations/gitlab.go 1.67% <0.00%> (-0.09%) ⬇️
modules/migrations/migrate.go 20.00% <0.00%> (-0.96%) ⬇️
services/pull/temp_repo.go 31.62% <0.00%> (-2.57%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 49.79% <0.00%> (-1.26%) ⬇️
services/pull/pull.go 33.39% <0.00%> (-0.77%) ⬇️
modules/notification/webhook/webhook.go 39.61% <0.00%> (-0.59%) ⬇️
models/issue.go 51.48% <0.00%> (-0.47%) ⬇️
models/pull.go 52.19% <0.00%> (+0.77%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77171ab...7f31f24. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2020
zeripath
zeripath reviewed Apr 20, 2020
View reviewed changes
zeripath
zeripath reviewed Apr 20, 2020
View reviewed changes
zeripath
zeripath reviewed Apr 20, 2020
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Apr 20, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2020
@6543
Copy link
Member Author

6543 commented Apr 20, 2020

ping lgtm

@zeripath zeripath merged commit 5bfb9bc into go-gitea:master Apr 20, 2020
@zeripath zeripath changed the title [Feature] on Gitlab Migration - take approvals as reviews When migrating from Gitlab map Approvals to approving Reviews Apr 20, 2020
@6543 6543 deleted the migrations-gitlab-add-reviews branch April 20, 2020 12:38
@6543 6543 mentioned this pull request Apr 20, 2020
Open
24 tasks
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543 @zeripath
When migrating from Gitlab map Approvals to approving Reviews (go-git…
10b6525 
…ea#11147)

When migrating from Gitlab map Gitlab Approvals to approving Reviews

Co-Authored-By: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Feature] add migration support for Reviews to gitlab migration
5 participants
@6543 @codecov-io @lafriks @zeripath @GiteaBot