Skip to content

Conversation

techknowlogick
Copy link
Member

Fix #10290

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #10292 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10292      +/-   ##
==========================================
+ Coverage   43.68%   43.73%   +0.05%     
==========================================
  Files         585      585              
  Lines       81017    81017              
==========================================
+ Hits        35392    35434      +42     
+ Misses      41234    41201      -33     
+ Partials     4391     4382       -9
Impacted Files Coverage Δ
models/user.go 49.54% <ø> (ø) ⬆️
services/pull/pull.go 32.43% <0%> (-1.51%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
models/error.go 30.95% <0%> (+0.54%) ⬆️
modules/git/repo.go 49.08% <0%> (+2.29%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
modules/git/command.go 89.56% <0%> (+2.6%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️
modules/git/utils.go 70.14% <0%> (+4.47%) ⬆️
services/pull/patch.go 66.03% <0%> (+5.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791b109...cc2a972. Read the comment docs.

@techknowlogick techknowlogick merged commit c0bc987 into go-gitea:master Feb 16, 2020
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch February 16, 2020 07:56
zeripath pushed a commit to zeripath/gitea that referenced this pull request Feb 16, 2020
lafriks pushed a commit that referenced this pull request Feb 16, 2020
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacklist manifest.json, milestones user
6 participants