Skip to content

Fix reply on code review #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix reply on code review #10257

merged 1 commit into from
Feb 13, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 13, 2020

backport from #10227

@lunny lunny added the type/bug label Feb 13, 2020
@lunny lunny added this to the 1.11.1 milestone Feb 13, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2020
@lafriks lafriks merged commit 987cd27 into go-gitea:release/v1.11 Feb 13, 2020
@lunny lunny deleted the lunny/fix_reply2 branch February 13, 2020 10:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @lafriks @guillep2k @6543 @GiteaBot