Skip to content

Bug fixes and unit tests for org_team #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2017
Merged

Bug fixes and unit tests for org_team #1016

merged 1 commit into from
Feb 23, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Feb 22, 2017

  • Unit tests for models/org_team.go
  • Fix a bug in DeleteTeam(..) where stale entries in the team_repo table were not deleted.
  • Some minor cleanups in models/org_team.go (remove unused functions, fix misformated error message, etc.)

@andreynering
Copy link
Contributor

andreynering commented Feb 23, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2017
@lunny
Copy link
Member

lunny commented Feb 23, 2017

Build faild

@ethantkoenig
Copy link
Member Author

ethantkoenig commented Feb 23, 2017

@lunny Lint error from #1017, restarted.

@appleboy
Copy link
Member

appleboy commented Feb 23, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 23, 2017
@lunny lunny merged commit 4f3880f into go-gitea:master Feb 23, 2017
@ethantkoenig ethantkoenig deleted the org_team_test branch February 23, 2017 16:45
@tboerger tboerger added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 27, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ethantkoenig @andreynering @lunny @appleboy @tboerger