Skip to content

[API] ListIssues add filter for milestones #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 30, 2020
Merged

[API] ListIssues add filter for milestones #10148

merged 7 commits into from
Apr 30, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 5, 2020 •
edited
Loading

close #10147

  • as tile
  • extend test

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2020
@6543 6543 force-pushed the issue-query-milestone branch from 96b42e6 to 223b562 Compare February 27, 2020 20:11
@6543 6543 force-pushed the issue-query-milestone branch from 02ce19d to de0720d Compare April 22, 2020 15:30
@6543 6543 changed the title [WIP] [API] ListIssues add filter for milestones [API] ListIssues add filter for milestones Apr 22, 2020
@6543 6543 mentioned this pull request Apr 22, 2020
Closed
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 22, 2020
@techknowlogick techknowlogick added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Apr 22, 2020
@6543 6543 mentioned this pull request Apr 27, 2020
Merged
@6543
Copy link
Member Author

6543 commented Apr 27, 2020

Moved refactor to #11225

@6543 6543 force-pushed the issue-query-milestone branch from 0b1c9c8 to 41ee3cd Compare April 27, 2020 00:31
lafriks
lafriks reviewed Apr 27, 2020
View reviewed changes
@6543 6543 force-pushed the issue-query-milestone branch from 4a00270 to 24818b6 Compare April 27, 2020 22:40
@6543 6543 force-pushed the issue-query-milestone branch from 24818b6 to c2ae44c Compare April 27, 2020 22:44
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit bfda0f3 into go-gitea:master Apr 30, 2020
@lafriks lafriks deleted the issue-query-milestone branch April 30, 2020 09:12
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
[API] ListIssues add filter for milestones (go-gitea#10148)
26bde72 
* Refactor Issue Filter Func

* ListIssues add filter for milestones

* as per @lafriks

* documentation ...
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[API] Search Issues By Milestone
6 participants
@6543 @guillep2k @lafriks @zeripath @techknowlogick @GiteaBot