oauth applications show up as failed logins when using ldap

[johanvdw]

We have a lot of logs like this:

2021/06/23 17:40:52 ...dels/login_source.go:844:UserSignIn() [W] Failed to login '3b5ade80-xxx' via 'ldaphost': user does not exist [uid: 0, name: 3b5ade80-xxx', keyid: 0]

Where the key 3b5ade80-xxx is actually an oauth key (used by droneci).

It is a bit inconvenient, because the large volume hides real issues. It would be better to show this warning only if the login is not found as a token either.

[zeripath]

What version of gitea are you using?

[zeripath]

But in any case I see the issue.

gitea/models/login_source.go

Line 859 in b223d36

log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)

should be debug unless the error is not a UserNotExist error.

[zeripath]

Now interestingly if this user had properly authenticated these shouldn't have ever got to the UserSignin stage so I'm not sure what's going on - likely this is related to the other oauth2 error people have been experiencing.