Rescript 11 suffix #125
Open
Rescript 11 suffix #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
reviewed
Aug 6, 2025
| "**/__tests__/**/*_test.bs.js", | ||
| "**/__tests__/**/*_test.res.mjs", |
There was a problem hiding this comment.
I wonder if the .bs.js suffix here should be retained, for backwards compatibility. I think that should be fine?
|
Also, the readme needs to be updated. I think that's pretty straightforward and that I could just do it myself, but if you'd like to in order to make sure it's correct, that'd be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest rescript suffix convention is .res and .res.mjs for modules.
rescript-jestworks almost out of the box except for a fiddly suffix issue where a new rescript app would be expecting to fetch jest.res.mjs with the current suffix naming.This PR renames the suffix in the config files that are compiled into the mjs file (which was bs.js before).