-
Notifications
You must be signed in to change notification settings - Fork 286
Support modular Firebase 9 #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks great! Just wondering should we also update the Readme (https://github.com/gladly-team/next-firebase-auth#using-the-firebase-apps)? You've already covered all the Examples which is great! Although this is not really a breaking change for |
|
@gavinharris-dev - Thanks for the feedback! I totally missed that readme section. I think linking to the official docs would be great, this official article covers the upgrade: https://firebase.google.com/docs/web/modular-upgrade. I will also add a small example in the readme directly for ease of use. |
4d57ab8 to
800a076
Compare
|
Any ETA on this ? At least Firebase UI is almost done migrating to Firebase 9. Its not official but the @next version seems to work pretty well. This package is now the only one waiting over a PR, that has already almost done everything for them. I wonder what's the wait. @HofmannZ Excellent Work and Kudos to you ! |
|
@dukesx - I'm done as far as this PR is concerned. I also saw that the Gladly team is setting up pipelines for v1 of the So, I assume this PR will soon be included in a prerelease of v1 🚀. |
Codecov Report
@@ Coverage Diff @@
## v1.x #291 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 25 25
Lines 484 484
Branches 167 167
=======================================
Hits 482 482
Misses 2 2
Continue to review full report at Codecov.
|
kmjennison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HofmannZ Thanks for the thorough PR. Looks great. Only one change: could you resolve the merge conflicts in the README?
|
@HofmannZ is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
@kmjennison - Rebased against the |
|
@kmjennison - It's this going to be included in a canary build? 🔜 |
|
@HofmannZ Yes, just released. Thanks! |
This PR adds support for Firebase 9. It does not change the API of
next-firebase-auth, so the refactor for users of the package will be relatively simple.This PR also updates the mocks, tests, and examples accordingly.