Skip to content

Fix build failure reported as success #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Fix build failure reported as success #223

merged 1 commit into from
Apr 8, 2025

Conversation

@WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Apr 8, 2025

Description

fixes build error not getting set in package build report, logging build as succeeded instead of failed, e.g.:

[foo:bar] error Command failed with exit code 1.
time="2025-04-08T15:29:18Z" level=fatal msg="build failed"
[foo:bar] package build succeded (134.56s) [prep: 0.0s | pull: 27.4s | test: 106.5s]
build failed

Related Issue(s)

Fixes #

How to test

Documentation

/hold

@WVerlaek WVerlaek requested review from aledbf and csweichel April 8, 2025 15:45
@WVerlaek WVerlaek merged commit 2b9dca9 into main Apr 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aledbf aledbf aledbf approved these changes

@csweichel csweichel Awaiting requested review from csweichel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WVerlaek @aledbf