Filter out IDEs on the backend #17324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
force-pushed
the
ide/experimental-ides-backend
branch
from
28792d0 to
752273f
Compare
filiptronicek
force-pushed
the
ide/browser-terminal
branch
from
a37ff85 to
450dc2b
Compare
filiptronicek
force-pushed
the
ide/experimental-ides-backend
branch
from
012ddaf to
831a59d
Compare
github-actions
bot
added
team: webapp
roboquat
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add xterm as an IDE * Move the IDE to our GCP registry 🎉 * Also resolve the source code commit for IDEs in `ide-service` * Add feature flag * Xterm => terminal * Revert "Also resolve the source code commit for IDEs in `ide-service`" This reverts commit 06aee00. * always add `<iframe>` to the top of `<body>` * Add the next non-jb IDE :) * Add latest image * Filter out IDEs on the backend (#17324) * Address review comments Never mutate `s.ideConfig` itself and make an in-memory copy of it to not use it every time. * Pre-compute outside * Stringify config instead of options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold