Skip to content

Uniformly use proxy to get the configuration of configcat #16942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2023
Merged

Uniformly use proxy to get the configuration of configcat #16942

merged 3 commits into from
Mar 23, 2023

Conversation

@iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Mar 21, 2023 •
edited by laushinka
Loading

Description

This PR adds consistency for the ConfigCat endpoint we use in Gitpod. Currently, most internal components use https://cdn.configcat.com/ directly and external clients (like VS Code Desktop) use our proxy (gitpod.io/configcat), which is preferred (we control caching there). This PR unifies all code to use our ConfigCat proxy.

There is a new configuration field of the supervisor named EnabledConfigCat and a corresponding environment variable on the server, GITPOD_CONFIGCAT_ENABLED.

Related Issue(s)

Relates to #16906 and #16903

How to test

  1. Open this PR in gitpod.io
  2. use kubectl describe deployment server to check the CONFIG_CAT relate env is setting correct.
  3. use kubectl describe pod ws-{instanceID} to check GITPOD_CONFIGCAT_ENABLED is set.
  4. change something in configcat, make sure it can still work.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

werft-gitpod-dev-com bot commented Mar 21, 2023

started the job as gitpod-build-pd-configcat.1 because the annotations in the pull request description changed
(with .werft/ from main)

filiptronicek
filiptronicek reviewed Mar 21, 2023
View reviewed changes
@iQQBot iQQBot marked this pull request as ready for review March 22, 2023 07:01
@iQQBot iQQBot requested review from a team March 22, 2023 07:01
@iQQBot iQQBot requested a review from a team as a code owner March 22, 2023 07:01
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: IDE team: staff-engineers labels Mar 22, 2023
easyCZ
easyCZ reviewed Mar 22, 2023
View reviewed changes
easyCZ
easyCZ reviewed Mar 22, 2023
View reviewed changes
easyCZ
easyCZ reviewed Mar 22, 2023
View reviewed changes
easyCZ
easyCZ reviewed Mar 22, 2023
View reviewed changes
@iQQBot iQQBot force-pushed the pd/configcat branch 2 times, most recently from 742e9f9 to d36f905 Compare March 22, 2023 08:21
@easyCZ
Copy link
Member

easyCZ commented Mar 22, 2023

Cool, we can keep it with backwards compatibility and cleanup, after we roll it out.

@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 22, 2023

Cool, we can keep it with backwards compatibility and cleanup, after we roll it out.

@easyCZ Could you give an approve?

easyCZ
easyCZ approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also normalize how the config is specified in the installer. Right now, there's some info passed into the proxy, and some passed into the Webapp.Experiments config. We should only one place for these

@roboquat roboquat added size/L and removed size/M labels Mar 22, 2023
@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 22, 2023

We should also normalize how the config is specified in the installer. Right now, there's some info passed into the proxy, and some passed into the Webapp.Experiments config. We should only one place for these

Yeah, I remove these 2 unused configs, because it's same as default value.

@akosyakov
Copy link
Member

akosyakov commented Mar 22, 2023

@filiptronicek Are you taking of a review from IDE side? Don't want to intervene.

@iQQBot iQQBot requested a review from csweichel as a code owner March 22, 2023 14:57
akosyakov
akosyakov approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not try, code wise looks good.

/hold

if someone else wants to review, otherwise merge when are ready

filiptronicek
filiptronicek reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iQQBot did something change for the supervisor? I cannot see GITPOD_CONFIGCAT_ENABLED, although the server deployment has both CONFIGCAT_SDK_KEY and CONFIGCAT_BASE_URL set correctly 🤔.

@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 22, 2023 •
edited by werft-gitpod-dev-com bot
Loading

did something change for the supervisor? I cannot see GITPOD_CONFIGCAT_ENABLED, although the server deployment has both CONFIGCAT_SDK_KEY and CONFIGCAT_BASE_URL set correctly 🤔.

Ah, we use ide-service to set env, but we don't enabled configcat in ide-service, added in e5450a5

filiptronicek
filiptronicek approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looks good

@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 23, 2023 •
edited by filiptronicek
Loading

To unblock merge, I plan to move commit 5835bcc to another PR

@roboquat roboquat added size/M and removed size/L labels Mar 23, 2023
@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 23, 2023

/unhold

@roboquat roboquat merged commit b465d06 into main Mar 23, 2023
@roboquat roboquat deleted the pd/configcat branch March 23, 2023 10:01
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Mar 24, 2023
@roboquat roboquat added the deployed: IDE IDE change is running in production label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@easyCZ easyCZ easyCZ approved these changes

@akosyakov akosyakov akosyakov approved these changes

@filiptronicek filiptronicek filiptronicek approved these changes

@csweichel csweichel Awaiting requested review from csweichel

Assignees

No one assigned

Labels

deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production release-note-none size/M team: IDE team: staff-engineers team: webapp Issue belongs to the WebApp team

Projects

🍎 WebApp Team
Status: In Validation

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iQQBot @easyCZ @akosyakov @filiptronicek @roboquat