Skip to content

[common-go] Support rate limiting by enum key #16899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

[common-go] Support rate limiting by enum key #16899

merged 1 commit into from
Mar 17, 2023

Conversation

@WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Mar 17, 2023 •
edited
Loading

Description

Support gRPC rate limiting on keys that are enums

Related Issue(s)

Allows us to rate limit by workspace type here https://github.com/gitpod-io/ops/issues/6831

How to test

Tested in a preview env, by configuring a rate limit on ws-manager-mk2's SetTimeout endpoint, key-ed on the type enum field:

"/wsman.WorkspaceManager/SetTimeout": {
  "block": true,
  "bucketSize": 1,
  "refillInterval": "30s",
  "key": "type",
  "keyCacheSize": 10
}

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek self-assigned this Mar 17, 2023
@WVerlaek WVerlaek marked this pull request as ready for review March 17, 2023 14:09
@WVerlaek WVerlaek requested a review from a team as a code owner March 17, 2023 14:09
easyCZ
easyCZ approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit

components/common-go/grpc/ratelimit_test.go
Expectation: Expectation{Found: true},
},
{
Name: "enum field",
Copy link
Member

@easyCZ easyCZ Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat merged commit 5cf9fca into main Mar 17, 2023
@roboquat roboquat deleted the wv/rate-limit-enum-key branch March 17, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees

@WVerlaek WVerlaek

Labels

release-note-none size/S team: staff-engineers

Projects

No open projects
🌌 Workspace Team
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WVerlaek @easyCZ @roboquat