[Dashboard] Open Project Context URLs in new tab #16521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhant Khare <[email protected]>
|
started the job as gitpod-build-ref-external-link.1 because the annotations in the pull request description changed |
gtsiolis
approved these changes
Feb 23, 2023
Contributor
gtsiolis
left a comment
gtsiolis
left a comment
There was a problem hiding this comment.
Thanks for making this change, @Siddhant-K-code! 🔮
Although it seems like a low-impact change, and we should try to rely on browser standards for opening links in new tabs (e.g. CMD+ Click), I understand how this why this interaction can be currently frustrating as it's hard to differentiate these external links.
This also affects other dashboard areas, like the links on the branch names under each project.
Still, this looks like a good MVC. Let's merge this!
Cross-posting for visibility from #7232:
We could consider:
- Limiting the amount of external links as much as possible, or especially avoid using the same design with internal links
- Introducing an external links icon that can be shown at the end of the link text
- Consolidating the design of the links so that it's a bit more clear when a link is an external link across the product
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always Open Project Context URLs (i.e. Repository URL of GitHub/GitLab/Bitbucket URLs) in new tab to not loose context of Gitpod Dashboard.
Related Issue(s)
Fixes #
How to test
/projectsor/projects/<YOUR_PROJECT_NAME>Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh