Don't include previewctl in dev image #14795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads-hartmann
force-pushed
the
mads/dont-include-previewctl-in-image
branch
from
cf60c7e to
330cf3d
Compare
mads-hartmann
force-pushed
the
mads/dont-include-previewctl-in-image
branch
5 times, most recently
from
7ffe73e to
96f0bcc
Compare
mads-hartmann
force-pushed
the
mads/dont-include-previewctl-in-image
branch
from
96f0bcc to
9fba4b8
Compare
|
|
mads-hartmann
changed the title
github-actions
bot
added
team: SID
team: devx
team: IDE
team: workspace
vulkoingim
approved these changes
Nov 22, 2022
Furisto
approved these changes
Nov 22, 2022
ArthurSens
approved these changes
Nov 22, 2022
felladrin
approved these changes
Nov 22, 2022
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
previewctlfrom the Dockerfile in favour of installing it in prebuilds through aninittask.leeway run dev/preview/previewctl:installwill now build and copy the binary over to/workspace/preview/bin./workspace/binhas been created and added to the $PATH.This makes it much easier for us to iterate on
previewctlas we won't have to rebuild the dev image and update all references to it (triggering review from every team) for every change we make.Related Issue(s)
Fixes #14149
How to test
That preview environments from Werft still works (example)
That
previewctlis available in workspacesRelease Notes
Documentation
N/A
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh