Self Hosted: Can add one more users than my license allows me to

[lucasvaltl]

Bug description

This is specific to self-hosted. I was able to add one more user than I should have as per the seats on my license. Note that this occurred when I had 2 seats allowed on my license and then tried to add a third (which worked) and a fourth (which was blocked).

Steps to reproduce

Created a loom video to walk you through it: https://www.loom.com/share/6d1d3e1324cc40a389b936c13956714b

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

[mrsimonemms]

When I did the development on this, I used the threshold of 10 users and my recollection is that it worked. My hope is that there's a weird issue that affects only user counts < 10, but that seems incredibly unlikely.

Useful links

• gitpod/components/licensor/ee/pkg/licensor/licensor.go

  Line 214 in b090f1c

  func (e *Evaluator) HasEnoughSeats(seats int) bool {

• gitpod/components/licensor/typescript/ee/src/index.ts

  Line 56 in 5166afd

  public hasEnoughSeats(seats: number): boolean {

• gitpod/components/server/ee/src/user/user-service.ts

  Line 81 in 5166afd

  if (!this.licenseEvaluator.hasEnoughSeats(userCount)) {

• gitpod/components/licensor/typescript/ee/src/module.cc

  Line 142 in b090f1c

  void HasEnoughSeatsM(const FunctionCallbackInfo<Value> &args) {

• gitpod/components/licensor/typescript/ee/src/module.cc

  Line 94 in b090f1c

  void EnabledM(const FunctionCallbackInfo<Value> &args) {

The two examples in module.cc would be where I'd start as it's one with the complex logic and I don't really know C, so it's all a bit of guesswork what I did here

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gtsiolis]

Closing as the licensor component has been removed in #16983. Cc @aledbf @AlexTugarev @geropl