Add error report #39
Merged
Add error report #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
mustard-mh
reviewed
Mar 16, 2023
src/telemetryReporter.ts
Outdated
| const analyticsClientFactory = async (key: string): Promise<BaseTelemetryClient> => { | ||
| let segmentAnalyticsClient = new SegmentAnalytics(key); | ||
|
|
||
| const gitpodHost = vscode.workspace.getConfiguration('gitpod').get<string>('host')!; |
Contributor
There was a problem hiding this comment.
It should get inside function itself in case user changed gitpod host?
Contributor
There was a problem hiding this comment.
I changed it, revert this change if it's not correct
Member
Author
There was a problem hiding this comment.
yeah this is kinda tricky, I was thinking about this yesterday if we assume there's never a remote windows when changing gitpod host then it makes sense to move inside, if not then this is the correct place as remote windows already connected should keep using the original host
mustard-mh
reviewed
Mar 16, 2023
Contributor
|
All good with locally packaged Results |
Contributor
|
|
Contributor
|
We will need better way to call Let's first ship this changes 👍 Thank you @jeanp413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gitpod-io/gitpod#16871