Add support for release and deployment events in webhooks #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabby
requested changes
Jun 14, 2021
| .withParam("pipeline_events", hook.getPipelineEvents(), false) | ||
| .withParam("wiki_events", hook.getWikiPageEvents(), false) | ||
| .withParam("enable_ssl_verification", hook.getEnableSslVerification(), false) | ||
| .withParam("url", hook.getUrl(), true) |
Collaborator
There was a problem hiding this comment.
Can you remove the formatting change here?
| public static final String OBJECT_KIND = "deployment"; | ||
|
|
||
| private String status; | ||
| private String statusChanged_at; |
Collaborator
There was a problem hiding this comment.
I'm not sure the name is correct. Should be statusChangedAt
Comment on lines
+40
to
+46
| public String getStatusChanged_at() { | ||
| return statusChanged_at; | ||
| } | ||
|
|
||
| public void setStatusChanged_at(String statusChanged_at) { | ||
| this.statusChanged_at = statusChanged_at; | ||
| } |
Collaborator
There was a problem hiding this comment.
Don't forget to update getter and setter here.
| String message = "Unsupported X-Gitlab-Event, event Name=" + eventName; | ||
| LOGGER.warning(message); | ||
| throw new GitLabApiException(message); | ||
| case IssueEvent.X_GITLAB_EVENT: |
Collaborator
There was a problem hiding this comment.
Can you remove the formatting change here?
| String message = "Unsupported event object_kind, object_kind=" + event.getObjectKind(); | ||
| LOGGER.warning(message); | ||
| throw new GitLabApiException(message); | ||
| case BuildEvent.OBJECT_KIND: |
Collaborator
There was a problem hiding this comment.
Can you remove the formatting change here?
| String message = "Unsupported event object_kind, object_kind=" + event.getObjectKind(); | ||
| LOGGER.warning(message); | ||
| throw new GitLabApiException(message); | ||
| case BuildEvent.OBJECT_KIND: |
Collaborator
There was a problem hiding this comment.
Can you remove the formatting change here?
Contributor
|
fixes #758 |
Contributor
|
hi @jabby i handled your requests on my fork
not sure on how to merged this, i can't supplement this pull-request; do i create a new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following webhooks were missing for projects:
I need both for my project, so decided to add them here. I have tested them with my own GitLab instance, it works great so far.
There are no integration tests for webhooks currently, so I have not added tests for them.